Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Julia: fix argmax/argmin for NDArray #13871

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Julia: fix argmax/argmin for NDArray #13871

merged 1 commit into from
Jan 18, 2019

Conversation

iblislin
Copy link
Member

  • fix 0-based index output to 1-based index

close #13786

--

julia> x = NDArray([1. 2 3; 4 5 6])
2×3 NDArray{Float64,2} @ CPU0:
 1.0  2.0  3.0
 4.0  5.0  6.0

julia> argmax(x, dims = 1)
1×3 NDArray{Float64,2} @ CPU0:
 2.0  2.0  2.0

julia> argmax(x, dims = 2)
2×1 NDArray{Float64,2} @ CPU0:
 3.0
 3.0

@iblislin
julia: fix argmax for NDArray
267e7c2 
- fix 0-based index output to 1-based index

close #13786
@iblislin iblislin changed the title julia: fix argmax for NDArray Julia: fix argmax/argmin for NDArray Jan 14, 2019
@iblislin iblislin closed this Jan 16, 2019
@iblislin iblislin reopened this Jan 16, 2019
@iblislin iblislin closed this Jan 17, 2019
@iblislin iblislin reopened this Jan 17, 2019
larroy
larroy reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larroy
Copy link
Contributor

larroy commented Jan 17, 2019

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed Julia NDArray labels Jan 17, 2019
@iblislin iblislin merged commit 61847be into master Jan 18, 2019
@iblislin iblislin deleted the ib/nd-argmax-argmin branch January 18, 2019 03:07
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@iblislin @stephenrawls
julia: fix argmax for NDArray (apache#13871)
d44ef61 
- fix 0-based index output to 1-based index

close apache#13786
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@iblislin
julia: fix argmax for NDArray (apache#13871)
be742d9 
- fix 0-based index output to 1-based index

close apache#13786
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larroy larroy larroy left review comments

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Julia argmax for NDArray
3 participants
@iblislin @larroy @marcoabreu